Back when 3.0 came out, I wrote a post about protection warrior DPS, stressing the priority of Shield Slam > Revenge > Devastate. As Veneretio points out, that has not turned out to be the real priority. If you’re sticking to that, because that’s a lot like our old rotation used to be like, you’re gimping your TPS and your DPS. You have to use your whole arsenal of tricks to compete. Just because a boss is immune to stuns does not mean you have no reason to use Concussion Blow and Shockwave as they will still cause the damage, it’s only the stun component they are immune to. Use them, whenever you can.
I personally find myself a bit limited by the overload of abilities and the global cooldown, based on my personal skills. There is so much going on that I do not find the time to use Heroic Strike often enough, aside from the free one that comes from my Revenge glyph. I could gnash my teeth at all that extra sweet DPS I am tossing out the window. That is definitely something I need to work on.
Thanks Vene, for once again offering food for thought.